Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMFileSystemInterface dependency to expo-media-library podspec #7809

Closed
wants to merge 2 commits into from

Conversation

Ashoat
Copy link
Contributor

@Ashoat Ashoat commented Apr 11, 2020

Why

This is necessary to build expo-media-library in a bare config that uses use_frameworks! in its Podfile on iOS. I think expo-media-library was overlooked in #6503. It uses UMFileSystemInterface here.

Test Plan

This is my first PR to Expo, so not entirely sure how to proceed. I made sure pod install worked.

Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
However, you need to commit modified pods files. So, please run pod install and commit changes.

@Ashoat
Copy link
Contributor Author

Ashoat commented Apr 16, 2020

For some reason, simply following the CONTRIBUTING.md, making this edit, and then running pod install leads to a whole bunch of untracked files in my working copy. It's hard for me to understand which of these files I need to be committing and which I don't.

I've made an educated guess based on #6503, but would appreciate further guidance if there is something I've missed.

There seems to be some issue where XCode/Cocoapods is generating separate [debug|release].xcconfig files, whereas the existing stuff just has a single .xcconfig for both. Here is what I am seeing in my working copy: https://gist.github.com/Ashoat/0f5602bdad7d77234a493ee0193f200e

@lukmccall
Copy link
Contributor

@Ashoat, I've created a new PR from your - #7861, which contains all the needed files. I believe you may use a different version of cocoapods (we're using 1.8.4).

Thanks for contributing 🎉🥇

Also, I'm closing this PR in favor of the new one.

@lukmccall lukmccall closed this Apr 16, 2020
@Ashoat
Copy link
Contributor Author

Ashoat commented Apr 16, 2020

Perfect, thank you @lukmccall. You’re right - I’m on 1.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants