[Android][FirebaseAnalytics] Adds Null Params Handling to Firebase's logEvent #7897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorbenprimke
force-pushed
the
tp-firebase-logeevent-fix
branch
from
1a050b5
to
5ece2d3
Compare
IjzerenHein
suggested changes
Apr 20, 2020
thorbenprimke
force-pushed
the
tp-firebase-logeevent-fix
branch
from
5ece2d3
to
794897c
Compare
…logEvent The params parameter of `logEvent` is nullable but it was passed to the MapArguments constructor which expects a non-null map. This caused a NPE when the Map’s keySet method is invoked. The fix is to simply pass null to Firebase `logEvent` method as that is handled as in no properties are being passed with the event. Added an additional test case for logEvent to the test suite and observed it failing without the fix and passing after the change.
thorbenprimke
force-pushed
the
tp-firebase-logeevent-fix
branch
from
794897c
to
76517e3
Compare
|
@IjzerenHein - do I need to do anything else in regards to getting the client and docs CI failures? It looks like the failures are unrelated. |
IjzerenHein
approved these changes
Apr 23, 2020
@thorbenprimke No there's nothing to do. We've verified and merged the PR. It will be included in the patch update for SDK 37 that will be released shortly. It has also been released to NPM, v2.3.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The params parameter of
logEventis nullable but it was passed to theMapArguments constructor which expects a non-null map.
This caused a NPE when the Map’s keySet method is invoked.
How
The fix is to simply pass null to Firebase
logEventmethod as thatis handled as in no properties are being passed with the event.
Test Plan
Added an additional test case for logEvent to the test suite and observed it failing without the fix and passing after the change.