Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][FirebaseAnalytics] Adds Null Params Handling to Firebase's logEvent #7897

Merged
merged 1 commit into from Apr 24, 2020
Merged

[Android][FirebaseAnalytics] Adds Null Params Handling to Firebase's logEvent #7897

merged 1 commit into from Apr 24, 2020

Commits on Apr 20, 2020

  1. [Android][FirebaseAnalytics] Adds Null Params Handling to Firebase's … 

    …logEvent

The params parameter of `logEvent` is nullable but it was passed to the
MapArguments constructor which expects a non-null map.
This caused a NPE when the Map’s keySet method is invoked.

The fix is to simply pass null to Firebase `logEvent` method as that
is handled as in no properties are being passed with the event.

Added an additional test case for logEvent to the test suite and observed it failing without the fix and passing after the change.
    @thorbenprimke
    thorbenprimke committed Apr 20, 2020
    Copy the full SHA
    76517e3 View commit details
    Browse the repository at this point in the history