Import @react-native-community/async-storage

[brentvatne]

Why

React Native 0.62 removes AsyncStorage from core.

How

I didn't yet. I just imported it. Meant to mark this as WIP, my mistake.

TODO

• Add scoping
• Use the same storage location as current AsyncStorage, or migrate automatically
• Ensure AsyncStorage data is available after ejecting (AsyncStorage state is lost when ejecting #8220)
• Document process for upgrading

Discussion

I'm not super stoked about having to import this library because we have to customize it so heavily for scoping. I'd rather us write expo-kv-storage based on the kv-storage spec, but I think this is the best move for compatibility with the React Native ecosystem currently (eg: Amplify, redux-persist, and so on).

[github-actions]

Native Component List for this branch is ready

[sjchmiela]

I was terrified for a second there, but it looks like React Native, fortunately, didn't remove AsyncStorage yet (at least in 0.62.2 to which we can upgrade). I verified that by using the pause/resume download demo in FileSystemScreen which uses AsyncStorage under the hood.

expo/apps/native-component-list/src/screens/FileSystemScreen.tsx

Lines 65 to 67 in bfb365d

	const downloadSnapshot = await this.download.pauseAsync();
	await AsyncStorage.setItem('pausedDownload', JSON.stringify(downloadSnapshot));
	alert('Download paused...');

Thus I will refrain from adding a launch-blocking label to this PR.

[brentvatne]

wow, that's a relief, thank you for verifying that @sjchmiela - i should have looked into it more, i just looked at the reactnative.dev docs and saw it wasn't listed anymore. instead of this pr i'm going to investigate if we can get @react-native-community/async-storage to use our asyncstorage backend when in managed workflow

[chrisdrackett]

what does this mean for web when (hopefully soon) the upgrade to react-native-web 0.12.x happens?

[brentvatne]

@chrisdrackett - check out react-native-async-storage/async-storage#368!

[chrisdrackett]

@brentvatne right, but can I use that with an expo managed app? maybe I'm just confused.