Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[local-authentication] added supported authentication type estimate with package manager #8431

Merged
merged 6 commits into from May 22, 2020

Conversation

byCedric
Copy link
Member

Why

See #8364

How

See #8364

Test Plan

See #7838 or https://snack.expo.io/@ouihealth/a78fc1

@byCedric byCedric requested a review from tsapeta May 22, 2020 14:08
@byCedric byCedric requested a review from lukmccall as a code owner May 22, 2020 14:08
@byCedric byCedric changed the title [docs] add back cleaned react native api docs [local-authentication] added supported authentication type estimate with package manager May 22, 2020
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik there is also PackageManager.FEATURE_IRIS – it might be worth to handle as well.

@byCedric byCedric force-pushed the @bycedric/local-auth/packagemanager-feature-detect branch from 9760f46 to 4b3fb6b Compare May 22, 2020 15:27
@tsapeta tsapeta merged commit 34808ad into master May 22, 2020
@tsapeta tsapeta deleted the @bycedric/local-auth/packagemanager-feature-detect branch May 22, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants