Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-notifications][expo-permissions] Move notification permission requesters to notifications package #8486

Merged
merged 9 commits into from May 27, 2020
Merged

[expo-notifications][expo-permissions] Move notification permission requesters to notifications package #8486

merged 9 commits into from May 27, 2020

Commits on May 27, 2020

  1. [expo-permissions] Remove EXUserNotificationPermissionRequester 

    It is replaced by expo-notification's EXUserFacingNotificationsPermissionsRequester, now included in Expo Client
    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    6d8e798 View commit details
    Browse the repository at this point in the history

  2. [expo-permissions][expo-notifications] Move remote notification permi… 

    …ssion requester to notifications

Fixes https://github.com/unimodules/react-native-unimodules/issues/136. expo-permissions no longer *may* register for push notifications.
    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    72f016d View commit details
    Browse the repository at this point in the history

  3. [expo-notifications] Implement a singleton module for remote notifica… 

    …tion permission progress

In ExpoKit remote notification requester depended on a notification being emitted by ExpoKit. Now we don't want to depend on ExpoKit, so thanks to unimodules we can just add a singleton module and receive the permission progress ourselves.
    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    7b7cf18 View commit details
    Browse the repository at this point in the history

  4. [expo-notifications] Register the "notifications" permission provider… 

    … at expo-permissions
    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    50f3e94 View commit details
    Browse the repository at this point in the history

  5. [ios] Reinstall pods

    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    3e74000 View commit details
    Browse the repository at this point in the history

  6. [bare-expo] Reinstall pods

    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    a565cda View commit details
    Browse the repository at this point in the history

  7. [changelog] Add changelog entries

    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    f62eef4 View commit details
    Browse the repository at this point in the history

  8. [docs] Update permissions.md for where notification-related permissio… 

    …ns requesters are included
    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    9601bfb View commit details
    Browse the repository at this point in the history

  9. [ios] Only save permissions that are expected to be scoped

    @sjchmiela
    sjchmiela committed May 27, 2020
    Configuration menu
    Copy the full SHA
    c46e9a2 View commit details
    Browse the repository at this point in the history