Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-notifications][expo-permissions] Move notification permission requesters to notifications package #8486

Merged
merged 9 commits into from May 27, 2020
Merged

[expo-notifications][expo-permissions] Move notification permission requesters to notifications package #8486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6d8e798
[expo-permissions] Remove EXUserNotificationPermissionRequester
sjchmiela May 26, 2020
72f016d
[expo-permissions][expo-notifications] Move remote notification permi…
sjchmiela May 26, 2020
7b7cf18
[expo-notifications] Implement a singleton module for remote notifica…
sjchmiela May 26, 2020
50f3e94
[expo-notifications] Register the "notifications" permission provider…
sjchmiela May 26, 2020
3e74000
[ios] Reinstall pods
sjchmiela May 26, 2020
a565cda
[bare-expo] Reinstall pods
sjchmiela May 26, 2020
f62eef4
[changelog] Add changelog entries
sjchmiela May 26, 2020
9601bfb
[docs] Update permissions.md for where notification-related permissio…
sjchmiela May 26, 2020
c46e9a2
[ios] Only save permissions that are expected to be scoped
sjchmiela May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/bare-expo/ios/Pods/.project_cache/installation_cache.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

490 changes: 253 additions & 237 deletions apps/bare-expo/ios/Pods/EXNotifications.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

165 changes: 61 additions & 104 deletions apps/bare-expo/ios/Pods/EXPermissions.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions ...e-expo/ios/Pods/Headers/Private/EXNotifications/EXRemoteNotificationPermissionRequester.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .../ios/Pods/Headers/Private/EXNotifications/EXRemoteNotificationPermissionSingletonModule.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...are-expo/ios/Pods/Headers/Private/EXPermissions/EXRemoteNotificationPermissionRequester.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .../bare-expo/ios/Pods/Headers/Private/EXPermissions/EXUserNotificationPermissionRequester.h
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions ...re-expo/ios/Pods/Headers/Public/EXNotifications/EXRemoteNotificationPermissionRequester.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...o/ios/Pods/Headers/Public/EXNotifications/EXRemoteNotificationPermissionSingletonModule.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...bare-expo/ios/Pods/Headers/Public/EXPermissions/EXRemoteNotificationPermissionRequester.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion apps/bare-expo/ios/Pods/Headers/Public/EXPermissions/EXUserNotificationPermissionRequester.h
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions docs/pages/versions/unversioned/sdk/permissions.md
View file
Open in desktop
Expand Up @@ -24,8 +24,8 @@ The following table shows you which permissions correspond to which packages.

| Permission type | Packages |
| --------------------------- | ----------------------------------------- |
| `NOTIFICATIONS` | `expo-permissions` |
| `USER_FACING_NOTIFICATIONS` | `expo-permissions` |
| `NOTIFICATIONS` | `expo-notifications` |
| `USER_FACING_NOTIFICATIONS` | `expo-notifications` |
| `LOCATION` | `expo-location` |
| `CAMERA` | `expo-camera`, `expo-barcode-scanner` |
| `AUDIO_RECORDING` | `expo-av` |
Expand Down
5 changes: 4 additions & 1 deletion ios/Exponent/Versioned/Core/UniversalModules/Permissions/EXScopedPermissions.m
View file
Open in desktop
Expand Up @@ -70,7 +70,10 @@ - (void)askForPermissionUsingRequesterClass:(Class)requesterClass
// ask for permission. If granted then save it as scope permission
void (^customOnResults)(NSDictionary *) = ^(NSDictionary *permission){
UM_ENSURE_STRONGIFY(self)
[self.permissionsService savePermission:permission ofType:permissionType forExperience:self.experienceId];
// if permission should be scoped save it
if ([self shouldVerifyScopedPermission:permissionType]) {
[self.permissionsService savePermission:permission ofType:permissionType forExperience:self.experienceId];
}
resolve(permission);
};

Expand Down
8 changes: 4 additions & 4 deletions ios/Pods/.project_cache/installation_cache.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.