Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-firebase-analytics] Updates Regex To Allow Numeric Chars #8516

Merged
merged 6 commits into from May 29, 2020
Merged

[expo-firebase-analytics] Updates Regex To Allow Numeric Chars #8516

merged 6 commits into from May 29, 2020

Commits on May 27, 2020

  1. [expo-firebase-analytics] Updates Regex To Allow Numeric Chars

    @thorbenprimke
    thorbenprimke committed May 27, 2020
    Copy the full SHA
    210fd66 View commit details
    Browse the repository at this point in the history

  2. Adds changelog

    @thorbenprimke
    thorbenprimke committed May 27, 2020
    Copy the full SHA
    3af8365 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Updated per feedback 

    - pulled out logic into isValidName
- added more tests
    @thorbenprimke
    thorbenprimke committed May 28, 2020
    Copy the full SHA
    843c3bd View commit details
    Browse the repository at this point in the history

  2. rebuild files

    @thorbenprimke
    thorbenprimke committed May 28, 2020
    Copy the full SHA
    ef56f7a View commit details
    Browse the repository at this point in the history

  3. updates changelog

    @thorbenprimke
    thorbenprimke committed May 28, 2020
    Copy the full SHA
    874dc64 View commit details
    Browse the repository at this point in the history

  4. Fixed user_id case

    @thorbenprimke
    thorbenprimke committed May 28, 2020
    Copy the full SHA
    c76f860 View commit details
    Browse the repository at this point in the history