Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-media-library] Add isNetworkAsset flag to ios #8800

Closed
wants to merge 4 commits into from
Closed

[expo-media-library] Add isNetworkAsset flag to ios #8800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20aea69
[expo-media-library] Update AssetInfo interface
Jun 14, 2020
593391b
[expo-media-library] Return isNetworkAsset on ios
Jun 14, 2020
53a787c
[expo-media-library] Update change log
Jun 14, 2020
1e54105
[expo-media-library] Update PR id in change log
Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/expo-media-library/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

### 🎉 New features

- Added `isNetworkAsset` key for `AssetInfo` result from `getAssetInfoAsync`. ([#8800])(https://github.com/expo/expo/pull/8800) by [@jarvisluong](https://github.com/jarvisluong)

### 🐛 Bug fixes

## 8.2.1 — 2020-05-29
Expand Down
1 change: 1 addition & 0 deletions packages/expo-media-library/build/MediaLibrary.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-media-library/build/MediaLibrary.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions packages/expo-media-library/ios/EXMediaLibrary/EXMediaLibrary.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ - (NSDictionary *)constantsToExport
completionHandler:^(PHContentEditingInput * _Nullable contentEditingInput, NSDictionary * _Nonnull info) {
result[@"localUri"] = [contentEditingInput.fullSizeImageURL absoluteString];
result[@"orientation"] = @(contentEditingInput.fullSizeImageOrientation);
result[@"isNetworkAsset"] = [info objectForKey:PHContentEditingInputResultIsInCloudKey];

CIImage *ciImage = [CIImage imageWithContentsOfURL:contentEditingInput.fullSizeImageURL];
result[@"exif"] = ciImage.properties;
Expand All @@ -424,6 +425,7 @@ - (NSDictionary *)constantsToExport
resultHandler:^(AVAsset * _Nullable asset, AVAudioMix * _Nullable audioMix, NSDictionary * _Nullable info) {
AVURLAsset *urlAsset = (AVURLAsset *)asset;
result[@"localUri"] = [[urlAsset URL] absoluteString];
result[@"isNetworkAsset"] = [info objectForKey:PHImageResultIsInCloudKey];
resolve(result);
}];
}
Expand Down
1 change: 1 addition & 0 deletions packages/expo-media-library/src/MediaLibrary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export type AssetInfo = Asset & {
location?: Location;
exif?: object;
isFavorite?: boolean; //iOS only
isNetworkAsset?: boolean; //iOS only
};

export type Location = {
Expand Down