New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-media-library] Add isNetworkAsset flag to ios #8800
Conversation
One thing I just noticed that the key
However, setting that flag to Otherwise, we would need to make the method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, we would need to make the method
getAssetInfoAsync
to be more configurable in JS side (in order to dynamically specifyPHContentEditingInputRequestOptions
andPHVideoRequestOptions
I believe that is the best option - I don't like making two calls for the asset.
Nevertheless, please update the documentation ;)
Yeah, I agree that making it more configurable is a good idea 👍 Does it also mean that |
You are right, the value will be nil |
I started working on an updated PR, hence closing this one |
# Why This is an enhanced PR from #8800 # How I added `options` as the optional second parameter to `MediaLibrary.getAssetInfoAsync`. # Test Plan Currently I modified `MediaDetailsScreen` in bare-expo app with payload of `shouldDownloadFromNetwork` to `false` so that the response payload also contains the field `isNetworkAsset`. # Open question Since this changes the public API of `MediaLibrary`, I wonder how should I update the bare-expo app to reflect this option?
Why & How
Mentioned in #8541
Test Plan
With a real device, make huge asset so that iCloud delete the local version, then open the test app and select that asset