add "ko-KR" in MobilePhoneLocale type #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohenke
approved these changes
Mar 26, 2023
gustavohenke
force-pushed
the
master
branch
2 times, most recently
from
3177f64
to
6e160b1
Compare
beeme1mr
pushed a commit
to open-feature/playground
that referenced
this pull request
Jun 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [express-validator](https://express-validator.github.io) ([source](https://togithub.com/express-validator/express-validator)) | [`^6.14.2` -> `^7.0.0`](https://renovatebot.com/diffs/npm/express-validator/6.15.0/7.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>express-validator/express-validator</summary> ### [`v7.0.1`](https://togithub.com/express-validator/express-validator/releases/tag/v7.0.1) [Compare Source](https://togithub.com/express-validator/express-validator/compare/v7.0.0...v7.0.1) - Fixed `checkSchema()` warning that known validators are unknown when its value is `false` - [#​1223](https://togithub.com/express-validator/express-validator/issues/1223) ### [`v7.0.0`](https://togithub.com/express-validator/express-validator/releases/tag/v7.0.0) [Compare Source](https://togithub.com/express-validator/express-validator/compare/v6.15.0...v7.0.0) 🚀 🙌 **First major version in almost 4 years!** 🚀 🤯 Thanks everybody for having the patience. Hopefully this version brings many improvements to your developer experience! #### Breaking changes 💥 - **Minimum supported Node.js version is now 14+** - Removed deprecated APIs - [#​993](https://togithub.com/express-validator/express-validator/issues/993) - Import paths `express-validator/check` and `express-validator/filter` - Sanitization-only middlewares (e.g. `sanitize()`, `sanitizeBody()`, etc) - Deprecated TypeScript types (`ValidationParamSchema` and `ValidationSchema`) - `isObject()` validator now assumes `options.strict = true` by default - Validation errors changed shape - Field validation errors `param` property has been renamed to `path` - `oneOf()` validation errors no longer have a `param: '_error'` property - (TypeScript only) The `ValidationError` type is now a [discriminated union](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions), it might be necessary to use `switch` or `if` statements to check that you're dealing with the type that you want to debug/format - `oneOf()` signature changed: from `oneOf(chains, message)` to `oneOf(chains, options: { message, errorType })` - `oneOf()` default error structure now groups errors by their... validation group!, instead of in a flat list Checkout the migration guide for examples on how to work around some of these: https://express-validator.github.io/docs/migration-v6-to-v7 #### New features ✨ - **Added validation for no unknown fields** - [#​558](https://togithub.com/express-validator/express-validator/issues/558), [#​578](https://togithub.com/express-validator/express-validator/issues/578), [#​612](https://togithub.com/express-validator/express-validator/issues/612), [#​1148](https://togithub.com/express-validator/express-validator/issues/1148), [#​809](https://togithub.com/express-validator/express-validator/issues/809), [#​927](https://togithub.com/express-validator/express-validator/issues/927), [#​1204](https://togithub.com/express-validator/express-validator/issues/1204) - **Added globstars (deep wildcard) support** - [#​790](https://togithub.com/express-validator/express-validator/issues/790), [#​1137](https://togithub.com/express-validator/express-validator/issues/1137), [#​1216](https://togithub.com/express-validator/express-validator/issues/1216) - Added support for multiple custom validators/sanitizers in `checkSchema()` - [#​552](https://togithub.com/express-validator/express-validator/issues/552), [#​1180](https://togithub.com/express-validator/express-validator/issues/1180) - Added request-level bail - [#​1100](https://togithub.com/express-validator/express-validator/issues/1100), [#​1214](https://togithub.com/express-validator/express-validator/issues/1214) - Added a `ExpressValidator` class which allows adding "persistent" custom validators, sanitizers, and options - [#​1077](https://togithub.com/express-validator/express-validator/issues/1077), [#​1079](https://togithub.com/express-validator/express-validator/issues/1079), [#​1209](https://togithub.com/express-validator/express-validator/issues/1209) - Added `oneOf()` support to `.if()` - [#​1170](https://togithub.com/express-validator/express-validator/issues/1170) - Added new error types to `oneOf()` - [#​956](https://togithub.com/express-validator/express-validator/issues/956), [#​1022](https://togithub.com/express-validator/express-validator/issues/1022) #### Bug fixes 🐛 - **Validating/sanitizing arrays no longer drops all but the first value** - [#​791](https://togithub.com/express-validator/express-validator/issues/791), [#​755](https://togithub.com/express-validator/express-validator/issues/755), [#​704](https://togithub.com/express-validator/express-validator/issues/704), [#​1002](https://togithub.com/express-validator/express-validator/issues/1002) - Added missing `ko-KR` to `MobilePhoneLocale` - [#​1218](https://togithub.com/express-validator/express-validator/issues/1218), [#​1219](https://togithub.com/express-validator/express-validator/issues/1219) - Don't silently fail when setting `withMessage` and `not` in schemas - [#​664](https://togithub.com/express-validator/express-validator/issues/664) #### New Contributors - [@​Yoowatney](https://togithub.com/Yoowatney) made their first contribution in [express-validator/express-validator#1219 **Full Changelog**: express-validator/express-validator@v6.15.0...v7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/playground). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ni4zIiwidXBkYXRlZEluVmVyIjoiMzUuOTYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added the missing 'ko-KR' line. #1218
To-do list
+) If necessary, I can provide test code for adding 'ko-KR' line