Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to transform-runtime plugin #7725

Closed
wants to merge 1 commit into from

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Sep 24, 2019

By default, babel assumes babel/helpers version 7.0.0-beta.0, this PR explicitly resolves the helpers to match the provide functions.

See: babel/babel#10261

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@topaxi
Copy link
Contributor Author

topaxi commented Sep 24, 2019

Nvm, I see this repo uses an undocumented absoluteRuntime config which should do the same thing. Although we do see lots of duplicated _objectSpread and ownKeys helpers in our application.

@topaxi topaxi closed this Sep 24, 2019
@lock lock bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants