feat(v2): explicit babel/runtime version #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit ae31935 |
|
Deploy preview for docusaurus-preview ready! Built with commit ae31935 |
lex111
approved these changes
Dec 10, 2019
yangshun
approved these changes
Dec 10, 2019
9 tasks
6 tasks
lsroman
pushed a commit
to semrush/intergalactic
that referenced
this pull request
Feb 21, 2023
Fixing the problem of incorrect helper imports ## Description + Motivation and Context Due to a bug in babel-runtime, not all helpers are imported correctly, instead, some of them are simply inlined INTO EVERY module, which affects code size and performance degradation These are links to a detailed description of the problem babel/babel#10334 babel/babel#10261 facebook/docusaurus#2111 This fix will definitely improve code size and performance, but to make it even better, you need to get rid of **babel-runtime-helper** and use **@babel/preset-env** with properly configured **browserslist**, then native method will be used for the same code spread ## How has this been tested? All tests passed, build does not crash, website works locally ## Screenshots (if appropriate): **Before:** <img width="897" alt="before-core" src="https://user-images.githubusercontent.com/12624143/220091398-99e0fe54-7e46-414d-ae20-7f2221069909.png"> **After:** <img width="800" alt="after-core" src="https://user-images.githubusercontent.com/12624143/220091435-6b364fce-513b-4b53-894a-6caadac2593b.png"> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See babel/babel#10261 and babel/babel#10261 (comment)
By default transform-runtime assumes that @babel/runtime@7.0.0 is installed. If you have later versions of @babel/runtime but did not specify version, transform-runtime will only use the helper from 7.0.0 resulting in larger bundle size.
Better to be explicit
Inspired from facebook/create-react-app#7726
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan