misc: update CONTRIBUTING to reflect status quo #5989
Conversation
Josh-Cena
added
the
pr: maintenance
Josh-Cena
added
pr: documentation
CONTRIBUTING.md
Outdated
| @@ -170,6 +169,10 @@ Copy and paste this to the top of your new file(s): | |||
|
|
|||
| In order to accept your pull request, we need you to submit a CLA. You only need to do this once, so if you've done this for another Facebook open source project, you're good to go. If you are submitting a pull request for the first time, the Facebook GitHub Bot will reply with a link to the CLA form. You may also [complete your CLA here](https://code.facebook.com/cla). | |||
|
|
|||
| After you have signed the CLA, the CLA bot would automatically update the PR status. There's no need to open a new PR. | |||
|
|
|||
| **CLAs are required for us to merge your pull request.** While we value your effort and are willing to wait for you to come back and address the reviews in case you are unavailable sending the pull request, pull requests that are ready to merge but have CLA missing and no response from the author **will be closed within two weeks of opening**. If you have further questions, please stay in touch with us. | |||
There was a problem hiding this comment.
It's better to formalize this: we would close PRs without CLA within two weeks. It's better than waiting forever on a PR that can't be merged.
|
✔️ [V2] 🔨 Explore the source changes: 04eccaa 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619ba61af885a700083f8559 😎 Browse the preview: https://deploy-preview-5989--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5989--docusaurus-2.netlify.app/ |
|
Size Change: +47 B (0%) Total Size: 892 kB
ℹ️ View Unchanged
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks for that 👍
There's another place where we have similar text that should probably be kept in sync (still has a ref to CircleCI for example)
https://docusaurus.io/community/contributing
Maybe there are some sections that can be shared thanks to MDX? 🤷♂️
|
|
||
| ## Example | ||
| The various types of commits: |
There was a problem hiding this comment.
worth mentioning that it's mostly for maintainers when squashing commits, we don't care too much about internal PR commits
Motivation
The CONTRIBUTING is quite old, made some updates & cleanups. Also removed the legacy extending-remarkable writeup from v1.
Have you read the Contributing Guidelines on pull requests?
Yes