chore(plugin-pwa): change core-js version in package.json to v3 #5995
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: polish
|
✔️ [V2] 🔨 Explore the source changes: 4e4d4a9 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619cd7665da1ef000965434f 😎 Browse the preview: https://deploy-preview-5995--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5995--docusaurus-2.netlify.app/ |
|
Size Change: -1 B (0%) Total Size: 892 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We already use core-js v3 in the actual code (in babel settings), but it's funny that we still declared core-js v2 in package.json. This hasn't caused much trouble so far because the core provides core-js v3.
We can't rid ourselves of core-js v2 entirely, however, because react-live@2.2.3 depends on it. react-live doesn't work with React v17 yet (#5556), and it's on my hate-list of dependencies😅 Users who use pwa but not live-codeblock may be able to get rid of core-js in their node_modules.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The PWA still works in deploy preview