Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-pwa): change core-js version in package.json to v3 #5995

Merged
merged 1 commit into from Nov 23, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

We already use core-js v3 in the actual code (in babel settings), but it's funny that we still declared core-js v2 in package.json. This hasn't caused much trouble so far because the core provides core-js v3.

We can't rid ourselves of core-js v2 entirely, however, because react-live@2.2.3 depends on it. react-live doesn't work with React v17 yet (#5556), and it's on my hate-list of dependencies馃槄 Users who use pwa but not live-codeblock may be able to get rid of core-js in their node_modules.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

The PWA still works in deploy preview

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 23, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2021
@netlify
Copy link

netlify bot commented Nov 23, 2021

鉁旓笍 [V2]

馃敤 Explore the source changes: 4e4d4a9

馃攳 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619cd7665da1ef000965434f

馃槑 Browse the preview: https://deploy-preview-5995--docusaurus-2.netlify.app

@github-actions
Copy link

鈿★笍 Lighthouse report for the changes in this PR:

Category Score
馃煚 Performance 77
馃煝 Accessibility 98
馃煝 Best practices 100
馃煝 SEO 100
馃煝 PWA 95

Lighthouse ran on https://deploy-preview-5995--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -1 B (0%)

Total Size: 892 kB

鈩癸笍 View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.3 kB 0 B
website/build/assets/css/styles.********.css 100 kB 0 B
website/build/assets/js/main.********.js 477 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.2 kB 0 B
website/build/blog/index.html 37.8 kB 0 B
website/build/docs/index.html 44 kB +1 B (0%)
website/build/docs/installation/index.html 51.7 kB -2 B (0%)
website/build/index.html 29.5 kB 0 B
website/build/tests/docs/index.html 25.2 kB 0 B
website/build/tests/docs/standalone/index.html 21.7 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants