New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): allow partially backticked markdown h1 contentTitles #8314
fix(utils): allow partially backticked markdown h1 contentTitles #8314
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Fun, isn't this function only used for sanitizing metadata like browser tab title? Does it work when rendering? |
Yeah, this is a start, but I want to try more. Just blocked on #8315 for testing page changes 😄 |
Or, I guess while that gets worked on, can we get this as a partial fix in the meantime? I think this will at least partially improve the situation? |
Pre-flight checklist
Motivation
See #8294 - I want h1s with inline code please 😄
Test Plan
I ... don't have one beyond unit tests.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#8294 - would you like me to file an issue? Or can someone convert that to one?