Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): normalize input for poll option #8342

Merged
merged 4 commits into from Nov 17, 2022
Merged

fix(core): normalize input for poll option #8342

merged 4 commits into from Nov 17, 2022

Commits on Nov 15, 2022

  1. fix(core): normalize input for poll option 

    This change normalizes input for the poll option to either a boolean or number to meet the specs required by Webpack config

fixes facebook#8306
    @mhnaeem
    mhnaeem committed Nov 15, 2022
    Copy the full SHA
    89471c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. fix(core): normalize input for poll option 

    This change normalizes input for the poll option to either a boolean or number to meet the specs required by Webpack config.
Move the function into the docusaurus.mjs file as requested.

fixes facebook#8306
    @mhnaeem
    mhnaeem committed Nov 16, 2022
    Copy the full SHA
    0efb26d View commit details
    Browse the repository at this point in the history

  2. fix(core) correct the jsdoc comment to accept undefined value

    @mhnaeem
    mhnaeem committed Nov 16, 2022
    Copy the full SHA
    d630381 View commit details
    Browse the repository at this point in the history

  3. fix(core): remove unwanted line since no description is needed

    @mhnaeem
    mhnaeem committed Nov 16, 2022
    Copy the full SHA
    75e2a39 View commit details
    Browse the repository at this point in the history