Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): normalize input for poll option #8342

Merged
merged 4 commits into from Nov 17, 2022
Merged

fix(core): normalize input for poll option #8342

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89471c3
fix(core): normalize input for poll option
mhnaeem Nov 15, 2022
0efb26d
fix(core): normalize input for poll option
mhnaeem Nov 16, 2022
d630381
fix(core) correct the jsdoc comment to accept undefined value
mhnaeem Nov 16, 2022
75e2a39
fix(core): remove unwanted line since no description is needed
mhnaeem Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/docusaurus/bin/docusaurus.mjs
View file
Open in desktop
Expand Up @@ -104,6 +104,23 @@ cli
)
.action(deploy);

/**
* @param {string | undefined} value
* @returns {boolean | number}
*/
function normalizePollValue(value) {
if (value === undefined || value === '') {
return false;
}

const parsedIntValue = Number.parseInt(value, 10);
if (!Number.isNaN(parsedIntValue)) {
return parsedIntValue;
}

return value === 'true';
}

cli
.command('start [siteDir]')
.description('Start the development server.')
Expand All @@ -122,6 +139,7 @@ cli
.option(
'--poll [interval]',
'use polling rather than watching for reload (default: false). Can specify a poll interval in milliseconds',
normalizePollValue,
)
.option(
'--no-minify',
Expand Down