Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-google-tag-manager): add new google-tag-manager plugin + deprecate google-analytics plugin #8470

Merged
merged 8 commits into from Dec 29, 2022
Merged

feat(plugin-google-tag-manager): add new google-tag-manager plugin + deprecate google-analytics plugin #8470

merged 8 commits into from Dec 29, 2022

Conversation

lanegoolsby
Copy link
Contributor

@lanegoolsby lanegoolsby commented Dec 21, 2022 •
edited by slorber

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Related issues/PRs

fix #7221

fix #8471

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 21, 2022
@lanegoolsby lanegoolsby marked this pull request as draft December 21, 2022 03:53
@netlify
Copy link

netlify bot commented Dec 21, 2022 •
edited

✅ [V2]

Name Link
🔨 Latest commit 414a61a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63adb04bd2ed310008e75860
😎 Deploy Preview https://deploy-preview-8470--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 21, 2022 •
edited

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 84 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 76 🟢 100 🟢 100 🟢 100 🟢 90 Report

@lanegoolsby lanegoolsby mentioned this pull request Dec 21, 2022
Closed
2 tasks
@lanegoolsby lanegoolsby marked this pull request as ready for review December 21, 2022 15:41
@Josh-Cena Josh-Cena changed the title feat (Google Tag Manager) Initial commit of GTM feat(plugin-google-tag-manager): add plugin Dec 21, 2022
@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 21, 2022
@slorber slorber mentioned this pull request Dec 29, 2022
Closed
2 tasks
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Dec 29, 2022
@slorber slorber changed the title feat(plugin-google-tag-manager): add plugin feat(plugin-google-tag-manager): add new google-tag-manager plugin + deprecate google-analytics plugin Dec 29, 2022
@slorber slorber merged commit 428af8a into facebook:main Dec 29, 2022
slorber pushed a commit that referenced this pull request Jan 26, 2023
@lanegoolsby @slorber
feat(plugin-google-tag-manager): add new google-tag-manager plugin + …
003729e 
…deprecate google-analytics plugin #8470
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
@Addono Addono mentioned this pull request Jan 30, 2023
Closed
3 tasks
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber left review comments

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Google Tag Manager plugin to enhance the current gtag plugin Google Analytics 4
4 participants
@lanegoolsby @slorber @facebook-github-bot @Josh-Cena