fix: pass root in babel config
#12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2022
SimenB
commented
Apr 19, 2022
commit 0b5c1d0d2d8568e7e7e5cdab46690f9ccf4eaad1 Merge: 4d2ebc4 49a5eca Author: Simen Bekkhus <sbekkhus91@gmail.com> Date: Tue Apr 19 15:03:01 2022 +0200 Merge branch 'main' into multiprj-babel commit 4d2ebc4 Author: Bradford Lemley <bradfordlemley@gmail.com> Date: Mon Feb 4 10:29:31 2019 -0700 Add tests for a few other babel config methods commit 4070442 Author: Bradford Lemley <bradfordlemley@gmail.com> Date: Mon Feb 4 08:14:39 2019 -0700 Apply patch from jestjs#7794 (comment). commit 51d008c Author: Bradford Lemley <bradfordlemley@gmail.com> Date: Sun Feb 3 11:03:28 2019 -0700 Configure babel cwd to be project rootDir commit 0dc6df1 Author: Bradford Lemley <bradfordlemley@gmail.com> Date: Sun Feb 3 15:08:05 2019 -0700 Add test demonstrating babel behavior difference individually vs. multiprj
SimenB
changed the title
root in babel configroot in babel config
1 task
tasshi-me
added a commit
to kintone/js-sdk
that referenced
this pull request
May 17, 2022
From jestjs/jest#12689, jest passes `rootDir` option to babel-jest. If rootDir is project sub-directory (e.g. `src/`, `__tests__/`), babel cannot load babel.config.js in project root.
tasshi-me
added a commit
to kintone/js-sdk
that referenced
this pull request
May 19, 2022
* chore(deps): update jest monorepo to v28 * test: fix jest.config.js From jestjs/jest#12689, jest passes `rootDir` option to babel-jest. If rootDir is project sub-directory (e.g. `src/`, `__tests__/`), babel cannot load babel.config.js in project root. * chore(rest-api-client): fix type error for dom (#1513) * test(create-plugin): fix jest.config.js * chore(rest-api-client): add type definition of Blob and BlobPart Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Masaharu TASHIRO <masatsr.kit@gmail.com> Co-authored-by: tasshi / Masaharu TASHIRO <33759872+mshrtsr@users.noreply.github.com> Co-authored-by: Masashi Hirano <shisama07@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setting
rootmakes sure babel doesn't look for config outside of the root of the Jest project.Closes #7794
Closes #12331
Test plan
Green CI