Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require minimum typescript@3.8 #9823

Merged
merged 3 commits into from May 2, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 16, 2020

Summary

Breaking change, so need to wait for Jest 26. The version will probably be bumped to 3.9 or whatever is the latest at the time of our release

Test plan

馃殌

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@ahnpnl
Copy link
Contributor

ahnpnl commented Apr 16, 2020

Does jest have a minimum typescript version for jest 25 ? If yes, we would like to follow the same minimum version for ts-jest

@SimenB
Copy link
Member Author

SimenB commented Apr 16, 2020

25 should work down to and including TS 3.4

@codecov-io
Copy link

Codecov Report

Merging #9823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9823   +/-   ##
=======================================
  Coverage   64.89%   64.89%           
=======================================
  Files         289      289           
  Lines       12233    12233           
  Branches     3030     3032    +2     
=======================================
  Hits         7939     7939           
  Misses       3654     3654           
  Partials      640      640           
Impacted Files Coverage 螖
packages/jest-console/src/CustomConsole.ts 77.55% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update da63789...fdbc943. Read the comment docs.

@cpojer cpojer merged commit f776624 into jestjs:master May 2, 2020
@SimenB SimenB deleted the remove-downlevel branch August 5, 2020 14:03
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants