Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (**BREAKING**): require minimum typescript@3.4 #1530

Merged
merged 1 commit into from Apr 16, 2020
Merged

chore (**BREAKING**): require minimum typescript@3.4 #1530

merged 1 commit into from Apr 16, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 16, 2020

Summary

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 16, 2020 15:10
@ahnpnl ahnpnl changed the title chore(**BREAKING**): set required minimum typescript version to 3.4 chore(**BREAKING**): set required minimum typescript version to 3.4 Apr 16, 2020
@ahnpnl ahnpnl changed the title chore(**BREAKING**): set required minimum typescript version to 3.4 chore (**BREAKING**): set required minimum typescript version to 3.4 Apr 16, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4420

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.036%

Totals Coverage Status
Change from base Build 4419: 0.0%
Covered Lines: 1184
Relevant Lines: 1219

💛 - Coveralls

@ahnpnl ahnpnl changed the title chore (**BREAKING**): set required minimum typescript version to 3.4 chore (**BREAKING**): require minimum typescript@3.4 Apr 16, 2020
@ahnpnl ahnpnl merged commit 8ad8822 into kulshekhar:master Apr 16, 2020
@ahnpnl ahnpnl deleted the set-minium-typescript-version branch April 16, 2020 17:51
@ahnpnl ahnpnl mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants