Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crlf): add ending space to avoid env: node\r: No such file or di… #549

Merged
merged 1 commit into from Mar 8, 2023

Conversation

sibelius
Copy link
Contributor

@sibelius sibelius commented Mar 8, 2023

…rectory, fix #424

Copy link

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Daniel15
Copy link
Member

Daniel15 commented Mar 8, 2023

I'm worried that someone saving the file with an editor that automatically strips out trailing spaces will remove the spaces, but for now I think this is OK! Thanks.

@jakeboone02
Copy link
Contributor

jakeboone02 commented Apr 1, 2023

Hello, I just found this issue when trying to get jscodeshift to run with Bun. See oven-sh/bun#2516.

While I think Bun should ultimately work around the issue, the solution in this PR does not actually resolve it in Bun's case (see oven-sh/bun#2516 (comment)), it just leads to other issues.

Is there any way jscodeshift could just ship LF line endings for /bin/jscodeshift.js? I think a .gitattributes file like this would work:

bin/jscodeshift.js eol=lf

I'd be happy to submit a PR to that effect. Update: #555.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version: 0.12.0. /usr/bin/env: ‘node\r’: No such file or directory
5 participants