New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force LF line endings in bin/jscodeshift.js and remove spaces after shebang #555
Conversation
Thanks - I'll try to cut a new release soon. |
Thanks! 🚀 |
Is there a release published with this fix? |
I'm going to publish a new version soon. I'll try to have it done by the end of the weekend.
--
Regards,
Daniel Lo Nigro
https://d.sb[https://d.sb/]
…Sent from my phone
May 6, 2023 3:57:06 PM Juzer Zarif ***@***.***>:
Is there a release published with this fix?
—
Reply to this email directly, view it on GitHub[#555 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAAWOHNA26DNI6V54TY6TADXE3JMZANCNFSM6AAAAAAWP42SAM].
You are receiving this because you modified the open/close state.[Tracking image][https://github.com/notifications/beacon/AAAWOHNEEHM3YU7TD2HKKJLXE3JMZA5CNFSM6AAAAAAWP42SAOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS3UBSKK.gif]
|
It was sort of a showstopper for me so I’ve updated the evcodeshift fork. Until Daniel gets the changes in you might be able to evcodeshift a spin (shilling for free testing)evcodeshiftnpmjs.comSent from my iPhoneOn May 6, 2023, at 19:02, Daniel Lo Nigro ***@***.***> wrote:
I'm going to publish a new version soon. I'll try to have it done by the end of the weekend.
--
Regards,
Daniel Lo Nigro
https://d.sb[https://d.sb/]
Sent from my phone
May 6, 2023 3:57:06 PM Juzer Zarif ***@***.***>:
Is there a release published with this fix?
—
Reply to this email directly, view it on GitHub[#555 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAAWOHNA26DNI6V54TY6TADXE3JMZANCNFSM6AAAAAAWP42SAM].
You are receiving this because you modified the open/close state.[Tracking image][https://github.com/notifications/beacon/AAAWOHNEEHM3YU7TD2HKKJLXE3JMZA5CNFSM6AAAAAAWP42SAOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS3UBSKK.gif]
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
npm is giving me an error when I try to publish:
Not sure why I'm getting a 429 given I haven't used npm today 🤔 |
Fixed my npm issue. New version has been published. Thanks for the patience. I'm going to see if I can somehow automatically publish dev versions of jscodeshift. |
This seems to be a regression an reintroduce the original issue. Trying to run the codemod in https://tanstack.com/query/latest/docs/react/guides/migrating-to-v5 on the codebase of https://github.com/flathub/website/ leaves me with
Using linux with zsh (in vscode) |
Hmm I'm not sure how this could have regressed :/ I'll look into it. |
Normally don't most projects prevent these sorts of regressions by including an .editorconfig file and some fairly aggressive eslint/prettier configs? |
@EnolVolo We do have an |
@razzeee I'm unable to reproduce the issue. I tested on both Ubuntu 22.04 and Debian 12, and both can run jscodeshift without an error:
It may be something to do with that specific transform? I'm unsure. Please open a new issue with more debugging info if you need help. |
Sorry for the comotion, it's that standard npx bug again 🙄 So you need to run
|
This PR forces LF line endings for bin/jscodeshift.js and removes the spaces added after the shebang pragma in #549. I believe the spaces are not necessary as long as the line endings are LF and not CRLF.
See my comment about Bun here: #549 (comment)