feat: add unstable_renameRequire to allow disabling the require rename transform
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Bundling our kitchen sink app (3301 modules):
I'm finding I can only accurately measure savings with threading disabled. With threads enabled, the results can sometimes be slower, but are ~100ms faster (total average: 27,491ms). |
3 tasks
robhogan
changed the title
unstable_disableRequireRename to disable the require rename transformunstable_renameRequire to allow disabling the require rename transform
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 207 207
Lines 10734 10734
Branches 2675 2676 +1
=======================================
Hits 8961 8961
Misses 1773 1773 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renaming
requireto_$$_REQUIREis an extraneous babel traversal that apparently is used internally at Meta for additional dependency extraction. Since the modules are scoped as iife functions, and there's no special convention to preserve nativerequiresyntax, this transform does not appear to add any value to standard projects. Per advice from @robhogan, I've added a flag to disable this transform, which we can enable by default in Expo CLI.Saves ~165ms when transforming the production react renderer module.
Test plan