Failing test for false positive "setState on unmounted component" warning #15067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test for #15057.
Possibly relates to some cases of #14369.
The crux of the issue is that even if we use a guard variable, sometimes an effect can't
setState
without triggering a warning. In particular, this happens if:setState
on an unmounted component, and warnsI'm not sure how to fix it. I imagine I'd expect that if
flushPassiveEffects
here led to unmounting of that component, we ideally shouldn't warn here.I'm not sure if there are any bigger issues in cases where it's not unmounted though. Is this just a stray warning or is there a larger potential concern?