Bugfix: Dropped effects in Legacy Mode Suspense #18238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d0cfef:
|
In legacy mode, a component that suspends bails out and commit in its previous state. If the component previously had mounted effects, we must transfer those to the work-in-progress so they don't get dropped.
acdlite
force-pushed
the
bugfix-legacy-suspense-effect
branch
from
4ddf4a5
to
3d0cfef
Compare
sebmarkbage
approved these changes
Mar 6, 2020
Details of bundled changes.Comparing: 115cd12...3d0cfef react-noop-renderer
Size changes (stable) |
Details of bundled changes.Comparing: 115cd12...3d0cfef react-noop-renderer
Size changes (experimental) |
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Mar 19, 2020
* Failing: Dropped effects in Legacy Mode Suspense * Transfer mounted effects on suspend in legacy mode In legacy mode, a component that suspends bails out and commit in its previous state. If the component previously had mounted effects, we must transfer those to the work-in-progress so they don't get dropped.
This was referenced Mar 21, 2020
This was referenced Apr 21, 2020
This was referenced Apr 29, 2020
This was referenced Mar 8, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In legacy mode, a component that suspends bails out and commit in its previous state. If the component previously had mounted effects, we must transfer those to the work-in-progress so they don't get dropped.
Bug report: https://codesandbox.io/s/charming-almeida-k6tdv