Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Dropped effects in Legacy Mode Suspense #18238

Merged
merged 2 commits into from Mar 6, 2020
Merged

Bugfix: Dropped effects in Legacy Mode Suspense #18238

merged 2 commits into from Mar 6, 2020

Commits on Mar 6, 2020

  1. Failing: Dropped effects in Legacy Mode Suspense

    @acdlite
    acdlite committed Mar 6, 2020
    Copy the full SHA
    855aab3 View commit details
    Browse the repository at this point in the history

  2. Transfer mounted effects on suspend in legacy mode 

    In legacy mode, a component that suspends bails out and commit in
its previous state. If the component previously had mounted effects,
we must transfer those to the work-in-progress so they don't
get dropped.
    @acdlite
    acdlite committed Mar 6, 2020
    Copy the full SHA
    3d0cfef View commit details
    Browse the repository at this point in the history