Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix grpcWeb import in hub-web #2006

Merged
merged 1 commit into from
May 16, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented May 16, 2024

Motivation

We accidentally lost the code that was fixing up bad protoc js file generation for hub-web. Bring it back and fix compilation.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR updates the hub-web package to fix the grpcWeb import and replaces grpc with grpcWeb in the codebase.

Detailed summary

  • Updated hub-web package to fix grpcWeb import
  • Replaced grpc with grpcWeb in the codebase for consistency

The following files were skipped due to too many changes: packages/hub-web/src/generated/rpc.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label May 16, 2024
Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 62cfd27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hub-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 10:15pm

@sanjayprabhu sanjayprabhu merged commit 920f6c0 into farcasterxyz:main May 16, 2024
7 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_protoc branch May 16, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant