Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to @fastify/busboy #300

Merged
merged 3 commits into from
Dec 5, 2021
Merged

Migrate to @fastify/busboy #300

merged 3 commits into from
Dec 5, 2021

Conversation

kibertoad
Copy link
Member

@kibertoad kibertoad commented Dec 4, 2021

This replaces unsupported original version of busboy with our own fork, sporting the holy trifecta of security fixes, performance improvements, and a richer feature-set.
It is a semver minor change with no known breaking changes.

fixes #297

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kibertoad kibertoad marked this pull request as ready for review December 4, 2021 21:38
@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 4, 2021

I love it. Literally a drop-in-replacement :)

@@ -26,7 +25,7 @@
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^5.1.0",
"eslint-plugin-typescript": "^0.14.0",
"fastify": "^3.2.1",
"fastify": "^3.24.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for this version bump?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering the lack of package-lock, it's a noop anyway, just makes it easier to run ncu.

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kibertoad kibertoad merged commit 94065e3 into master Dec 5, 2021
@kibertoad kibertoad deleted the chore/fastify-busboy branch December 5, 2021 03:01
@darkgl0w darkgl0w mentioned this pull request Dec 5, 2021
4 tasks
@climba03003 climba03003 mentioned this pull request Dec 8, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BusBoy replacement?
5 participants