Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute tests using TAP, allow jest tests to fail #50

Merged
merged 3 commits into from May 22, 2021
Merged

Execute tests using TAP, allow jest tests to fail #50

merged 3 commits into from May 22, 2021

Conversation

kibertoad
Copy link
Member

Allows to fix CI considering the #49

@kibertoad kibertoad requested a review from mcollina May 22, 2021 09:15
mcollina
mcollina reviewed May 22, 2021
View reviewed changes
test-tap/requestContextPlugin.e2e.test.js
@@ -0,0 +1,193 @@
const request = require('superagent')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add use strict at the top

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kibertoad kibertoad merged commit a5cfd47 into master May 22, 2021
@kibertoad kibertoad deleted the feat/tap branch May 22, 2021 11:05
@voxpelli voxpelli mentioned this pull request Jun 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kibertoad @mcollina