typings for the route config based hooks no longer working since 4.16.0

[vidarc]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.16.0

Plugin version

No response

Node.js version

18.x

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

12.3

Description

The hooks specified in the options of a route no longer have the correct typings applied/resolved. They come back as any. The following code snippet works in 4.15.0, but breaks in 4.16.0

Steps to Reproduce

import Fastify from "fastify";

const fastify = Fastify();

fastify.get(
  "/route",
  {
    onError: (request, reply, error) => {
      request // is any
      reply // is any
      error // is any
    },
  },
  async () => ({ success: "yes" })
);

The same appears to be true for all the other hooks specified in this manner as well.

Interestingly, hooks added with addHook appear to have the correct typings resolved

Expected Behavior

No response

[Eomm]

Thanks for reporting!
Would you like to send a Pull Request to address this issue? Remember to add unit tests.

[mcollina]

Can you please include a script that compiles in v4.15.0 and it does not in v4.16.0. That would help in bisecting the problem.

[vidarc]

Do you need something more than the attached code snippet? That shows the problem between the 2 versions

[vidarc]

It's definitely due to #4655

If I take the types/route.d.ts file from before that PR was merged, the types work as expected

[mcollina]

Anything that I can quickly run in a bash shell that returns 1 if it fails. Opening an editor and trying to autocomplete is not great for git bisecting.

[Fdawgs]

closed by #4708