Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Google Cloud Functions example to Serverless Documentation #3445

Merged
merged 17 commits into from
Nov 16, 2021

Conversation

etino
Copy link
Contributor

@etino etino commented Nov 14, 2021

Added Google Cloud Functions example to use Fastify as requests handler. (Related to #3382)

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 14, 2021
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! 👏🏼

Just minor suggestions

docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
etino and others added 2 commits November 15, 2021 12:34
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@matthyk matthyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found 2 minor typos

docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
etino and others added 2 commits November 15, 2021 16:06
Co-authored-by: Matthias Keckl <53833818+matthyk@users.noreply.github.com>
Fix typo

Co-authored-by: Matthias Keckl <53833818+matthyk@users.noreply.github.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@etino etino requested review from Eomm and mcollina November 16, 2021 06:24
docs/Serverless.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks and then looks good to me.

docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
docs/Serverless.md Outdated Show resolved Hide resolved
etino and others added 8 commits November 16, 2021 14:16
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
etino and others added 2 commits November 16, 2021 14:18
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
@etino
Copy link
Contributor Author

etino commented Nov 16, 2021

Some tweaks and then looks good to me.

Thank you @jsumners 😃

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants