Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop @typescript-eslint/no-misused-promises #3741

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Drop @typescript-eslint/no-misused-promises #3741

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
820d8a8
Drop @typescript-eslint/no-misused-promises
mcollina Mar 3, 2022
fa2dd8f
??
mcollina Mar 3, 2022
b213509
updated steps
mcollina Mar 3, 2022
03f4312
moar fixes
mcollina Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:

- name: Lint code
run: |
echo 'this is an update'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

npm run lint

coverage-nix:
Expand Down
3 changes: 1 addition & 2 deletions types/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-misused-promises": ["error"]
"@typescript-eslint/no-non-null-assertion": "off"
},
"globals": {
"NodeJS": "readonly"
Expand Down