Drop @typescript-eslint/no-misused-promises

[mcollina]

Alternative to #3737.
I looked at the actual problem and the typescript rule has a serious bug.
Apparently it cannot figure out anymore that

fastify/test/types/hooks.test-d.ts

Lines 142 to 146 in b2ce3d5

	server.addHook('onRequest', async function (request, reply) {
	expectType<FastifyInstance>(this)
	expectType<FastifyRequest>(request)
	expectType<FastifyReply>(reply)
	})

should lint against the async overload we had.

Given this is correct code and we should get the CI green again, I'll land this as soon as it pass. If somebody can open an issue against the typescript-eslint project, that would be awesome.

Checklist

• run npm run test and npm run benchmark
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[xtx1130]

I have tried

"@typescript-eslint/no-misused-promises": ["error", {
          "checksVoidReturn": false
  }]

But it doesn't work for github ci. So I think we need to update the package version for github ci

[mcollina]

I'm landing this as a I have a theory that the pull-request-target check is now run from the main branch

[jsumners]

We should use pull_request_target. It was added to avoid exposing secrets to forks:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow. This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

[mcollina]

That's broken. It's running the code from the main branch and not the target branch.

[jsumners]

Right. The "base branch" is main. That's exactly what it is supposed to do.

[mcollina]

The full code that it runs is main, there is nothing of the current PR that is checkout or run. The code and workflow is now identical to main so it's kind of useless for this specific job where we need the current code.

[mcollina]

Check out #3737, apparently the updates to package.json and config files where not picked up.

[jsumners]

oops

[mcollina]

fixed

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.