chore: add node 18 to ci and benchmark #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems failing |
xtx1130
suggested changes
Apr 22, 2022
RafaelGSS
force-pushed
the
chore/hello-v18
branch
from
9168822
to
83c08d2
Compare
RafaelGSS
force-pushed
the
chore/hello-v18
branch
from
83c08d2
to
dd5e314
Compare
climba03003
reviewed
Apr 22, 2022
There was a problem hiding this comment.
Document update is missing.
https://github.com/fastify/fastify/blob/main/docs/Reference/LTS.md
climba03003
requested changes
Apr 22, 2022
climba03003
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
LGTM.
I am not going to block the 404 router changes.
It is the bug from find-my-way and I will send a fix to there.
Fdawgs
approved these changes
Apr 22, 2022
|
the fmw PR landed and it's released! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct