Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add node 18 to ci and benchmark #3843

Merged
merged 9 commits into from
Apr 23, 2022
Merged

chore: add node 18 to ci and benchmark #3843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edd8da7
chore: add node 18 to ci and benchmark
RafaelGSS Apr 20, 2022
215fa80
chore: remove v17 from ci
RafaelGSS Apr 22, 2022
93c15a4
fix: pass constraints to FindMyWay
RafaelGSS Apr 22, 2022
d8e9f8c
fix: bump eslint-config-n to v15
RafaelGSS Apr 22, 2022
dd5e314
test: adjust test to v18
RafaelGSS Apr 22, 2022
348daac
doc: update node v18
RafaelGSS Apr 22, 2022
b7cd51c
update: remove constraints to fourOhFour
RafaelGSS Apr 22, 2022
5ba7f64
update: add constraints until its not solved in find-my-way
RafaelGSS Apr 22, 2022
8cd2340
update: reset constraints fourOhFour
RafaelGSS Apr 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
outputs:
PR-BENCH-14: ${{ steps.benchmark-pr.outputs.BENCH_RESULT14 }}
PR-BENCH-16: ${{ steps.benchmark-pr.outputs.BENCH_RESULT16 }}
PR-BENCH-17: ${{ steps.benchmark-pr.outputs.BENCH_RESULT17 }}
PR-BENCH-17: ${{ steps.benchmark-pr.outputs.BENCH_RESULT18 }}
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
MAIN-BENCH-14: ${{ steps.benchmark-main.outputs.BENCH_RESULT14 }}
MAIN-BENCH-16: ${{ steps.benchmark-main.outputs.BENCH_RESULT16 }}
MAIN-BENCH-17: ${{ steps.benchmark-main.outputs.BENCH_RESULT17 }}
MAIN-BENCH-17: ${{ steps.benchmark-main.outputs.BENCH_RESULT18 }}
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
strategy:
matrix:
node-version: [14, 16, 17]
node-version: [14, 16, 18]
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -81,9 +81,9 @@ jobs:

---

**Node**: 17
**PR**: ${{ needs.benchmark.outputs.PR-BENCH-17 }}
**MAIN**: ${{ needs.benchmark.outputs.MAIN-BENCH-17 }}
**Node**: 18
**PR**: ${{ needs.benchmark.outputs.PR-BENCH-18 }}
**MAIN**: ${{ needs.benchmark.outputs.MAIN-BENCH-18 }}

- uses: actions-ecosystem/action-remove-labels@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

strategy:
matrix:
node-version: [14, 16, 17]
node-version: [14, 16, 17, 18]
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
os: [macos-latest, ubuntu-latest, windows-latest]

steps:
Expand Down