fix: use ajv for schema ref resolving #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ivan-tymoshenko
force-pushed
the
use-ajv-for-schema-ref-resolving
branch
from
ba919e0
to
376ac1c
Compare
|
@climba03003 Can you help with CI. I guess it is related to #3997. Some Ci works, some of them fail. Everything is ok on my local. |
|
It is strange that it pass |
|
I see the problem now. It install the |
ivan-tymoshenko
force-pushed
the
use-ajv-for-schema-ref-resolving
branch
from
376ac1c
to
0237dfa
Compare
mcollina
reviewed
Jun 22, 2022
2 tasks
2 tasks
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
This PR shows that all Fastify tests work with fastify/fast-json-stringify-compiler#14 and fastify/fast-json-stringify#462 changes.