test: refactor logger test

[climba03003]

1. Refactor to use async-await
2. fix sonic-boom never close file

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Eomm]

Must say that locally it works 😓
Will try to suggest something 🤝

[Eomm]

I read that the runners have been updated: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md

I would get a green pipeline first - then check the diff tbh

[Eomm]

@climba03003 It still fails - could it be an issue with something else and not related to the host? 🤔

Flaky over 9000

[jsumners]

The issue seems to be this recently added test:

fastify/test/route.test.js

Lines 1497 to 1509 in d0a1e8c

	test('using fastify.all when a catchall is defined does not degrade performance', { timeout: 5000 }, async t => {
	t.plan(1)
	const fastify = Fastify()
	fastify.get('/*', async (_, reply) => reply.json({ ok: true }))
	for (let i = 0; i < 100; i++) {
	fastify.all(`/${i}`, async (_, reply) => reply.json({ ok: true }))
	}
	t.pass()
	})

I had a suspicion at the time that the timeout would be unreliable in CI. The CI environment is not consistent and is very prone to taking an excessive amount of time to execute code. Not sure what to do about it.

[Eomm]

[climba03003]

We should remove node@20 first.

[Eomm]

We should remove node@20 first.

I had node19 failing for 2 runs.. I tried.. This is a poker match 🤦🏼

[climba03003]

It seems all good now?
I will do a rebase and cleanup.

[Eomm]

It seems all good now? I will do a rebase and cleanup.

It requires at least one manual re-run of all the failed job.. I wonder if the issue is that we run too many things

[climba03003]

I wonder if the issue is that we run too many things

We can split the logger.test.js into multiple files to see if it helps.

[climba03003]

Looks absolutely better.

[mcollina]

lgtm

[Eomm]

[Fdawgs]

You absolute wizards @climba03003 and @Eomm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.