Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infer correct hook handler #4945

Merged
merged 9 commits into from Aug 7, 2023
Merged

fix: infer correct hook handler #4945

merged 9 commits into from Aug 7, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 31, 2023 •
edited

This PR fixes the issue, that you could define async hook handlers, but they could contain the done callback.

Checklist

@github-actions github-actions bot added the typescript TypeScript related label Jul 31, 2023
@Uzlopak Uzlopak mentioned this pull request Jul 31, 2023
Merged
4 tasks
mcollina
mcollina approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Aug 1, 2023

Thanks! I think this should fix quite a lot of problem for folks.

Uzlopak
Uzlopak commented Aug 1, 2023
View reviewed changes
test/types/hooks.test-d.ts Outdated Show resolved Hide resolved
@Uzlopak Uzlopak marked this pull request as draft August 1, 2023 10:15
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 1, 2023

Changing to Draft, because it still needs some love

@Uzlopak Uzlopak marked this pull request as ready for review August 1, 2023 10:55
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 1, 2023

Ok, I thought about it and wanted to inform you about one drawback:

Because the method headers of the hook handlers are all different, typescript will throw the error on the wrong place.

image

It is an improvement, because we get an error in typescript when async and callback is mixed. But you get errors like Argument of type '"onClose"' is not assignable to parameter of type '"preClose"'

@BrendenInhelder BrendenInhelder mentioned this pull request Aug 1, 2023
Closed
4 tasks
metcoder95
metcoder95 reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

Haven't played in deep with the Types from fastify, but something like this could be ported to the route definition?

types/instance.d.ts Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 1, 2023 •
edited

Regarding the issue of wrong error... I will check if sorting the hooks by descending arity of the handler can help or not .

But first i go to the gym...

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 4, 2023

much better
@metcoder95

image

@Uzlopak Uzlopak changed the title fix: infer correct hook handler uzlopak: infer correct hook handler Aug 4, 2023
@Uzlopak Uzlopak changed the title uzlopak: infer correct hook handler fix: infer correct hook handler Aug 4, 2023
@Uzlopak Uzlopak requested a review from metcoder95 August 4, 2023 08:40
metcoder95
metcoder95 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mcollina
mcollina requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second look, this is not correct. the done callback must not be used when the function is async

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 7, 2023

@mcollina

It throws typings errors, when you define the function async and provide a callback parameter.
You can actually see this in my last screenshot. Also in the typings test, all of the combinations are expectError

mcollina
mcollina approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry I misunderstood this

@mcollina mcollina merged commit b4b4dc7 into main Aug 7, 2023
30 checks passed
@mcollina mcollina deleted the fix-inferring-hook-handler branch August 7, 2023 12:07
beyazit pushed a commit to beyazit/fastify that referenced this pull request Aug 9, 2023
@Uzlopak @beyazit
fix: infer correct hook handler (fastify#4945)
d86db42 
* fix: infer correct hook handler

* Update test/types/hooks.test-d.ts

* simplify

* remove duplicate typing tests

* remove duplicate test

* remove unused import

* fix

* fix linting
@Uzlopak Uzlopak mentioned this pull request Aug 22, 2023
Closed
2 tasks
renovate bot added a commit to tomacheese/telcheck that referenced this pull request Aug 27, 2023
@renovate
chore(deps): update dependency fastify to v4.22.0 (#261)
e4c8aa0 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`4.21.0` ->
`4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.21.0/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.21.0/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0)

#### What's Changed

- make FastifySchemaValidationError.params wider by
[@&#8203;cm-ayf](https://togithub.com/cm-ayf) in
[fastify/fastify#4476
- docs(ecosystem): add fastify-hashids by
[@&#8203;andersonjoseph](https://togithub.com/andersonjoseph) in
[fastify/fastify#4934
- fix: hasPlugin does not track parent plugins by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#4929
- docs: early hints plugin is fastify plugin by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4947
- chore: add pull request title check by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4951
- chore: Bump
[@&#8203;sinclair/typebox](https://togithub.com/sinclair/typebox) from
0.29.6 to 0.30.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#4952
- ci: improve pr title check by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4953
- ci: fix warnings in benchmark workflows by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4954
- docs: fix removeAdditional comment by
[@&#8203;G0maa](https://togithub.com/G0maa) in
[fastify/fastify#4948
- fix: Try to fix parser benchmark workflow by
[@&#8203;kibertoad](https://togithub.com/kibertoad) in
[fastify/fastify#4956
- fix: infer correct hook handler by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4945
- fix: do not double send the response if the request is destroyed but
not aborted by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#4963
- chore: Bump
[@&#8203;sinclair/typebox](https://togithub.com/sinclair/typebox) from
0.30.4 to 0.31.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#4973
- fix: bodyLimit must be applied on fully decoded body by
[@&#8203;sergburn](https://togithub.com/sergburn) in
[fastify/fastify#4969
- chore: updates
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
and
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
by [@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4977
- chore: use group dependencies in dependabot by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4979
- chore: fix ci bench by [@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#4983
- fix: require.cache is undefined breaks SEA by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4982
- ci: remove sync next wf by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4985
- docs: remove mixing ES6 and commomjs in the example by
[@&#8203;thenicolau](https://togithub.com/thenicolau) in
[fastify/fastify#4990
- fix: errorHandler callback should utilize TypeProvider by
[@&#8203;muan](https://togithub.com/muan) in
[fastify/fastify#4989
- types: add onRoute to ApplicationHookLookup by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4968
- chore: make tests pass on ipv4 only machine by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#4997
- fix: Set `FastifyRequest.id` type as a string by
[@&#8203;samchungy](https://togithub.com/samchungy) in
[fastify/fastify#4992

#### New Contributors

- [@&#8203;G0maa](https://togithub.com/G0maa) made their first
contribution in
[fastify/fastify#4948
- [@&#8203;thenicolau](https://togithub.com/thenicolau) made their first
contribution in
[fastify/fastify#4990
- [@&#8203;muan](https://togithub.com/muan) made their first
contribution in
[fastify/fastify#4989
- [@&#8203;samchungy](https://togithub.com/samchungy) made their first
contribution in
[fastify/fastify#4992

**Full Changelog**:
fastify/fastify@v4.21.0...v4.22.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Uzlopak added a commit that referenced this pull request Aug 29, 2023
@beyazit @cm-ayf
@andersonjoseph @Eomm @metcoder95 @Uzlopak @Fdawgs @dependabot @luisorbaiceta @G0maa @kibertoad
fix: remove http version check (#4962)
dbac4e0 
* make FastifySchemaValidationError.params wider (#4476)

* fix: FastifySchemaValidationError.params could be unknown

* refactor: use FastifySchemaValidationError instead of ValidationResult

* fix: export ValidationResult for backword compatibility

* test: add non-assignable test for AjvErrorObject

* docs(ecosystem): add fastify-hashids (#4934)

* fix: hasPlugin does not track parent plugins (#4929)

Co-authored-by: Carlos Fuentes <me@metcoder.dev>

* docs: early hints plugin is fastify plugin (#4947)

* docs: early hints plugin is fastify plugin

* fix

* Update docs/Guides/Ecosystem.md

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

---------

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

* chore: add pull request title check (#4951)

* chore: add pull request title check

* Update .github/workflows/pull-request-title.yml

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

---------

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

* chore: Bump @sinclair/typebox from 0.29.6 to 0.30.2 (#4952)

Bumps [@sinclair/typebox](https://github.com/sinclairzx81/typebox) from 0.29.6 to 0.30.2.
- [Commits](sinclairzx81/typebox@0.29.6...0.30.2)

---
updated-dependencies:
- dependency-name: "@sinclair/typebox"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: prove pr title check (#4953)

* improve pr title check

* Apply suggestions from code review

* fix

* fix

* Update .github/workflows/pull-request-title.yml

Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com>

* Apply suggestions from code review

---------

Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com>

* ci: fix warnings in benchmark workflows (#4954)

* improve pr title check

* Apply suggestions from code review

* fix

* fix

* ci: fix warnings in benchmark workflow

* Update .github/workflows/benchmark.yml

* Update .github/workflows/benchmark.yml

* docs: fix removeAdditional comment (#4948)

* docs(Validator Compiler): fix removeAdditional comment

* Update docs/Reference/Validation-and-Serialization.md

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

* fix: typo in comment

* Update docs/Reference/Validation-and-Serialization.md

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

---------

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

* fix: Try to fix parser benchmark workflow (#4956)

* fix: infer correct hook handler (#4945)

* fix: infer correct hook handler

* Update test/types/hooks.test-d.ts

* simplify

* remove duplicate typing tests

* remove duplicate test

* remove unused import

* fix

* fix linting

* fix: remove http version check

* test: remove unsupported http version

* remove obsolete documentation

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: cm-ayf <cm.ayf2734@gmail.com>
Co-authored-by: Anderson <andersonjoseph@mailfence.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Co-authored-by: Carlos Fuentes <me@metcoder.dev>
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luis Orbaiceta <luisorbaiceta@gmail.com>
Co-authored-by: Mohammed Gomaa <midomaxgomaa@gmail.com>
Co-authored-by: Igor Savin <iselwin@gmail.com>
Co-authored-by: Cem <cembkoztekin@gmail.com>
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Aug 30, 2023
@renovate
fix(deps): update dependency fastify to v4.22.0 (#9093)
bf999c6 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`4.21.0` ->
`4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.21.0/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.21.0/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0)

##### What's Changed

- make FastifySchemaValidationError.params wider by
[@&#8203;cm-ayf](https://togithub.com/cm-ayf) in
[fastify/fastify#4476
- docs(ecosystem): add fastify-hashids by
[@&#8203;andersonjoseph](https://togithub.com/andersonjoseph) in
[fastify/fastify#4934
- fix: hasPlugin does not track parent plugins by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#4929
- docs: early hints plugin is fastify plugin by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4947
- chore: add pull request title check by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4951
- chore: Bump
[@&#8203;sinclair/typebox](https://togithub.com/sinclair/typebox) from
0.29.6 to 0.30.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#4952
- ci: improve pr title check by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4953
- ci: fix warnings in benchmark workflows by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4954
- docs: fix removeAdditional comment by
[@&#8203;G0maa](https://togithub.com/G0maa) in
[fastify/fastify#4948
- fix: Try to fix parser benchmark workflow by
[@&#8203;kibertoad](https://togithub.com/kibertoad) in
[fastify/fastify#4956
- fix: infer correct hook handler by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4945
- fix: do not double send the response if the request is destroyed but
not aborted by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#4963
- chore: Bump
[@&#8203;sinclair/typebox](https://togithub.com/sinclair/typebox) from
0.30.4 to 0.31.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#4973
- fix: bodyLimit must be applied on fully decoded body by
[@&#8203;sergburn](https://togithub.com/sergburn) in
[fastify/fastify#4969
- chore: updates
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
and
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
by [@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4977
- chore: use group dependencies in dependabot by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4979
- chore: fix ci bench by [@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#4983
- fix: require.cache is undefined breaks SEA by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4982
- ci: remove sync next wf by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4985
- docs: remove mixing ES6 and commomjs in the example by
[@&#8203;thenicolau](https://togithub.com/thenicolau) in
[fastify/fastify#4990
- fix: errorHandler callback should utilize TypeProvider by
[@&#8203;muan](https://togithub.com/muan) in
[fastify/fastify#4989
- types: add onRoute to ApplicationHookLookup by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4968
- chore: make tests pass on ipv4 only machine by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#4997
- fix: Set `FastifyRequest.id` type as a string by
[@&#8203;samchungy](https://togithub.com/samchungy) in
[fastify/fastify#4992

##### New Contributors

- [@&#8203;G0maa](https://togithub.com/G0maa) made their first
contribution in
[fastify/fastify#4948
- [@&#8203;thenicolau](https://togithub.com/thenicolau) made their first
contribution in
[fastify/fastify#4990
- [@&#8203;muan](https://togithub.com/muan) made their first
contribution in
[fastify/fastify#4989
- [@&#8203;samchungy](https://togithub.com/samchungy) made their first
contribution in
[fastify/fastify#4992

**Full Changelog**:
fastify/fastify@v4.21.0...v4.22.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Sep 2, 2023
@renovate @jtoar
fix(deps): update dependency fastify to v4.22.0 (#9093)
1162b73 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.io/)
([source](https://togithub.com/fastify/fastify)) | [`4.21.0` ->
`4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.21.0/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.21.0/4.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0)

##### What's Changed

- make FastifySchemaValidationError.params wider by
[@&#8203;cm-ayf](https://togithub.com/cm-ayf) in
[fastify/fastify#4476
- docs(ecosystem): add fastify-hashids by
[@&#8203;andersonjoseph](https://togithub.com/andersonjoseph) in
[fastify/fastify#4934
- fix: hasPlugin does not track parent plugins by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#4929
- docs: early hints plugin is fastify plugin by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4947
- chore: add pull request title check by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4951
- chore: Bump
[@&#8203;sinclair/typebox](https://togithub.com/sinclair/typebox) from
0.29.6 to 0.30.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#4952
- ci: improve pr title check by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4953
- ci: fix warnings in benchmark workflows by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4954
- docs: fix removeAdditional comment by
[@&#8203;G0maa](https://togithub.com/G0maa) in
[fastify/fastify#4948
- fix: Try to fix parser benchmark workflow by
[@&#8203;kibertoad](https://togithub.com/kibertoad) in
[fastify/fastify#4956
- fix: infer correct hook handler by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4945
- fix: do not double send the response if the request is destroyed but
not aborted by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#4963
- chore: Bump
[@&#8203;sinclair/typebox](https://togithub.com/sinclair/typebox) from
0.30.4 to 0.31.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#4973
- fix: bodyLimit must be applied on fully decoded body by
[@&#8203;sergburn](https://togithub.com/sergburn) in
[fastify/fastify#4969
- chore: updates
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
and
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
by [@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4977
- chore: use group dependencies in dependabot by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4979
- chore: fix ci bench by [@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#4983
- fix: require.cache is undefined breaks SEA by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#4982
- ci: remove sync next wf by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4985
- docs: remove mixing ES6 and commomjs in the example by
[@&#8203;thenicolau](https://togithub.com/thenicolau) in
[fastify/fastify#4990
- fix: errorHandler callback should utilize TypeProvider by
[@&#8203;muan](https://togithub.com/muan) in
[fastify/fastify#4989
- types: add onRoute to ApplicationHookLookup by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#4968
- chore: make tests pass on ipv4 only machine by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#4997
- fix: Set `FastifyRequest.id` type as a string by
[@&#8203;samchungy](https://togithub.com/samchungy) in
[fastify/fastify#4992

##### New Contributors

- [@&#8203;G0maa](https://togithub.com/G0maa) made their first
contribution in
[fastify/fastify#4948
- [@&#8203;thenicolau](https://togithub.com/thenicolau) made their first
contribution in
[fastify/fastify#4990
- [@&#8203;muan](https://togithub.com/muan) made their first
contribution in
[fastify/fastify#4989
- [@&#8203;samchungy](https://togithub.com/samchungy) made their first
contribution in
[fastify/fastify#4992

**Full Changelog**:
fastify/fastify@v4.21.0...v4.22.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Uzlopak Uzlopak mentioned this pull request Nov 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

@climba03003 climba03003 Awaiting requested review from climba03003

@kibertoad kibertoad Awaiting requested review from kibertoad

Assignees
No one assigned
Labels
typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @mcollina @metcoder95