Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for New Apple Devices in Snapshot Generator #21554

Merged

Conversation

isandeepj
Copy link
Contributor

@isandeepj isandeepj commented Oct 5, 2023

By integrating these devices into the snapshot generator, users can now generate screenshots and experiences that align with the latest Apple hardware offerings.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

The motivation for this PR is to ensure that Fastlane's snapshot tool stays up-to-date with the latest Apple devices. As newer models are introduced, it's crucial for developers and testers to generate screenshots and experiences aligned with these devices. This change aims to bridge any existing gaps and provide broader compatibility for users.
#21551

Description

In this PR, I have added support for the following Apple devices:

  • iPhone: Added entries for the iPhone 14 and 15 series.
  • Apple Watch: Introduced support for Series 5, 6, 7, 9, and Ultra 2.
  • iPad Pro: Incorporated the 4th and 6th generation models.
  • Apple TV: Added the 4K 3rd generation model to the list of supported devices.

All modifications were tested to ensure accurate functionality with these devices.

Testing Steps

  1. Navigate to the snapshot configuration file.
  2. Update the device list to include any of the newly added devices.
  3. Run the snapshot tool to generate screenshots.
  4. Verify the output for accuracy and compatibility.

- Introduce iPhone 14 & 15 series
- Add Apple Watch Series 5, 6, 7, 9, and Ultra 2
- Incorporate iPad Pro 4th & 6th gen
- Include Apple TV 4K 3rd gen
@google-cla
Copy link

google-cla bot commented Oct 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@getaaron
Copy link
Collaborator

getaaron commented Oct 6, 2023

Thanks for the PR, @isandeepj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants