Let FastlanePty detect when externally invoked programs crash, harden it when using popen, and expose process statuses. #21618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are wrapped properly
…yError with a -1 error code
lacostej
changed the title
6 tasks
lacostej
commented
Nov 6, 2023
lacostej
commented
Nov 6, 2023
AliSoftware
approved these changes
Nov 17, 2023
lacostej
changed the title
TheMetalCode
added a commit
to TheMetalCode/fastlane
that referenced
this pull request
Nov 22, 2023
4 tasks
lacostej
pushed a commit
that referenced
this pull request
Dec 14, 2023
…xecutor crashes (#21536) * Force FastlanePty.spawn to return exit code if it ends up being nil for whatever reason * Actually, let's implement the fix right where the problem occurs, and add a test * Update fastlane_core/lib/fastlane_core/itunes_transporter.rb Co-authored-by: Aaron Brager <getaaron@gmail.com> * Remove unneeded nil catch given #21618 * Write more accurate test --------- Co-authored-by: Aaron Brager <getaaron@gmail.com>
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
…stlane#21618) Main changes: * Let FastlanePty detect when externally invoked programs crash * Harden it when using popen * Expose process_status into FastlanePtyError * Add unit tests * Add a helper C program used to investigate ruby behavior
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
…xecutor crashes (fastlane#21536) * Force FastlanePty.spawn to return exit code if it ends up being nil for whatever reason * Actually, let's implement the fix right where the problem occurs, and add a test * Update fastlane_core/lib/fastlane_core/itunes_transporter.rb Co-authored-by: Aaron Brager <getaaron@gmail.com> * Remove unneeded nil catch given fastlane#21618 * Write more accurate test --------- Co-authored-by: Aaron Brager <getaaron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #21536, I noticed that tests seem to be missing on FastlanePty. Adding some
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Here's the test that is failing e31a1d1