Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] fix cache issues in read-only mode #21767

Merged
merged 1 commit into from Jan 4, 2024

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Jan 3, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21762 .

Description

The cache can be used only when read-only mode is disabled.

Updates for spec_helper and new test structure copypasted from #21691.

Added test for read-only mode.

Looks better w/o spaces diff.

Testing Steps

Run the match action in read-only mode.

@nekrich nekrich marked this pull request as ready for review January 3, 2024 13:01
@nekrich
Copy link
Contributor Author

nekrich commented Jan 3, 2024

@rogerluan , @lacostej, please review.

@rogerluan
Copy link
Member

I'm OOO till next week, but I'll take a look when I'm back :)

@nekrich nekrich changed the title fix: match cache in read-only mode [match] fix cache issues in read-only mode Jan 3, 2024
@nekrich
Copy link
Contributor Author

nekrich commented Jan 3, 2024

I'm OOO till next week, but I'll take a look when I'm back :)

Sorry, it's a regression I've introduced by implementing a cache for the match 😭.
Can someone else look at this?

@nekrich
Copy link
Contributor Author

nekrich commented Jan 3, 2024

@joshdholtz , sorry for the ping. Can you please review and release #21767 and #21766 since there is a regression impacting a lot of folks?

@mlazari
Copy link

mlazari commented Jan 3, 2024

For reviewers of this PR - I verified and confirmed that this change fixes the issue for me (#21762 (comment))

@Lutzifer
Copy link
Contributor

Lutzifer commented Jan 4, 2024

I can also confirm that

gem "fastlane",  :git => "git@github.com:nekrich/fastlane.git", :branch => 'fix/match-readonly-mode'

fixes #21762

Good job and thank you!

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🫶

@joshdholtz joshdholtz merged commit 2ccb64c into fastlane:master Jan 4, 2024
2 checks passed
This was referenced Jan 4, 2024
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match "undefined method get_profiles" error with fastlane 2.218.0
5 participants