Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deliver] fetch live app info if no edit info is present, fixing scenario of having both macOS and iOS apps present #21472
[deliver] fetch live app info if no edit info is present, fixing scenario of having both macOS and iOS apps present #21472
Changes from 20 commits
c976e9a
23ea7c0
9453b77
d57b974
d62af0d
7d42af5
c1bdd94
f5187ff
dfbf80d
d04fb08
aae5bdd
5c161ef
66470dc
e016f01
896c292
89086aa
52bbce7
09f89e3
104ecdb
0cc2bfc
0e62085
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Unrelated to this PR]
@rogerluan we definitively need to improve our YARD doc on many of our model methods. This isn't clear at all from the definition of the
AppInfo#get_app_info_localizations
what that method is supposed to return, which makes it harder to read code that uses it like here and why Lore needed to uselocalizations.find
below.(After some digging, the answer is that it returns
Array<Spaceship::ConnectAPI::AppInfo>
; which makes sense in retrospect I guess, but was't obvious to me at first sight, and RubyMine isn't able to deduce it automatically)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that skipping upload here is causing a regression with editing the privacy url #21654
Is there a way we can force upload so that we can edit the privacy url even though none of the other localized app info will change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @loremattei @AliSoftware @rogerluan @kommen