[deliver] fetch live app info if no edit info is present, fixing scenario of having both macOS and iOS apps present

deliver/lib/deliver/upload_metadata.rb

@@ -90,7 +90,7 @@ def upload(options)
 
       app_store_version_localizations = verify_available_version_languages!(options, app, enabled_languages) unless options[:edit_live]
       app_info = fetch_edit_app_info(app)
-      app_info_localizations = verify_available_info_languages!(options, app, app_info, enabled_languages) unless options[:edit_live] || !updating_localised_app_info?(options, app, app_info)
+      app_info_localizations = verify_available_info_languages!(options, app, app_info, enabled_languages) unless options[:edit_live] || !updating_localized_app_info?(options, app, app_info)
 
       if options[:edit_live]
         # not all values are editable when using live_version
@@ -460,8 +460,8 @@ def retry_if_nil(message, tries: 5, wait_time: 10)
     end
 
     # Checking if the metadata to update includes localised App Info
-    def updating_localised_app_info?(options, app, app_info)
-      app_info = fetch_live_app_info(app) unless app_info
+    def updating_localized_app_info?(options, app, app_info)
+      app_info ||= fetch_live_app_info(app)
       unless app_info
         UI.important("Can't find edit or live App info. Skipping upload.")
         return false
@@ -490,14 +490,14 @@ def updating_localised_app_info?(options, app, app_info)
         end
       end
 
-      UI.message('No changes to localised App Info detected. Skipping upload.')
+      UI.message('No changes to localized App Info detected. Skipping upload.')
       return false
     end
 
     # Finding languages to enable
     def verify_available_info_languages!(options, app, app_info, languages)
       unless app_info
-        UI.user_error!("Cannot update languages - could not find an editable info")
+        UI.user_error!("Cannot update languages - could not find an editable App info. Verify that your app is in one of the editable states in App Store Connect")
         return
       end
 

deliver/spec/upload_metadata_spec.rb

@@ -270,7 +270,7 @@ def create_metadata(path, text)
           expect(app_info).to receive(:get_app_info_localizations).and_return([app_info_localization_en])
 
           # Get app info localization English (Used to compare with data to upload)
-          expect(app_info_localization_en).to receive(:name).and_return("")
+          expect(app_info_localization_en).to receive(:name).and_return('App Name')
 
           # Update version localization
           expect(version_localization_en).to receive(:update).with(attributes: {
@@ -437,10 +437,8 @@ def create_metadata(path, text)
 
           # Get number of versions (used for if whats_new should be sent)
           expect(Spaceship::ConnectAPI).to receive(:get_app_store_versions).and_return(app_store_versions)
-
           expect(version).to receive(:update).with(attributes: {})
 
-          # Get app info localization in English (used to compare with data to upload)
           uploader.upload(options)
         end
 
@@ -460,9 +458,8 @@ def create_metadata(path, text)
           expect(version).to receive(:update).with(attributes: {})
 
           # Get app info localization in English (used to compare with data to upload)
-          expect(app_info_localization_en).to receive(:name).and_return("App name")
+          expect(app_info_localization_en).to receive(:name).and_return('App name')
 
-          # Get app info localization in English (used to compare with data to upload)
           uploader.upload(options)
         end
       end
@@ -494,10 +491,10 @@ def create_metadata(path, text)
         expect(version).to receive(:get_app_store_version_localizations).and_return([version_localization_en])
 
         # Get app info localization in English (used to compare with data to upload)
-        expect(app_info_localization_en).to receive(:name).and_return("App name")
+        expect(app_info_localization_en).to receive(:name).and_return('App name')
 
         # Fail because app info can't be updated
-        expect(FastlaneCore::UI).to receive(:user_error!).with("Cannot update languages - could not find an editable info").and_call_original
+        expect(FastlaneCore::UI).to receive(:user_error!).with('Cannot update languages - could not find an editable App info. Verify that your app is in one of the editable states in App Store Connect').and_call_original
 
         # Get app info localization in English (used to compare with data to upload)
         expect { uploader.upload(options) }.to raise_error(FastlaneCore::Interface::FastlaneError)