ELECTRON-1019: Enable spellchecker for popup window #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrbsm
force-pushed
the
spellchecker-popup
branch
from
91c8345
to
8b13288
Compare
vrbsm
changed the title
KiranNiranjan
approved these changes
Feb 18, 2019
vrbsm
force-pushed
the
spellchecker-popup
branch
from
8b13288
to
543a6af
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable spellchecker to popup window ELECTRON-1019
Solution Approach
N/A
Documentation
Memory leak with use sandbox true and webFrame.setSpellCheckProvider link
Fix memory leak when using webFrame and spell checker (4-0-x) link
Related PRs
N/A
QA Checklist
Attach unit & spectron tests results in PDF format against the above task lists for this branch