Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELECTRON-1019: Enable spellchecker for popup window #571

Merged
merged 1 commit into from Feb 19, 2019
Merged

ELECTRON-1019: Enable spellchecker for popup window #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions js/preload/preloadMain.js
View file
Open in desktop
Expand Up @@ -86,10 +86,6 @@ const throttledSetIsInMeetingStatus = throttle(1000, function (isInMeeting) {
local.ipcRenderer.on('on-page-load', () => {
snackBar = new SnackBar();

// Enable spellchecker only for main window until
// the underline memory leak is fixed on electron
// https://github.com/electron/electron/issues/15459
if (window.name === 'main') {
webFrame.setSpellCheckProvider('en-US', true, {
spellCheck (text) {
return !local.ipcRenderer.sendSync(apiName, {
Expand All @@ -98,7 +94,6 @@ local.ipcRenderer.on('on-page-load', () => {
});
}
});
}

// only registers main window's preload
if (window.name === 'main') {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -87,7 +87,7 @@
"browserify": "16.2.3",
"chromedriver": "2.45.0",
"cross-env": "5.2.0",
"electron": "4.0.4",
"electron": "4.0.5",
"electron-builder": "20.38.4",
"electron-builder-squirrel-windows": "20.38.3",
"electron-chromedriver": "4.0.0-beta.1",
Expand Down