fix: emulator auth_time (#3608) #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made emulator auth_time match how auth_time is populated in production. (auth_time should match user's lastLoginAt in seconds)
lisajian
reviewed
Jul 28, 2021
There was a problem hiding this comment.
Overall, LGTM pending @yuchenshi's feedback. Thank you for the fix!
|
@yuchenshi @lisajian Resolved all 3 comments. I think that's everything! 👍 |
yuchenshi
approved these changes
Jul 28, 2021
|
Apparently linter is not happy about the code formatting, but we'll fix this on our side -- just don't delete your fork branch yet! |
lisajian
approved these changes
Jul 28, 2021
|
This is now merged and will be included in the next release. Thanks again for the help! |
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* fix: emulator auth_time (firebase#3608) Made emulator auth_time match how auth_time is populated in production. (auth_time should match user's lastLoginAt in seconds) * Check not null just in case lastLoginAt is 0 because of unit test clock mocking * Advance clock to verify auth_time is not refresh time * assert user.lastLoginAt is not undefined * Apply suggestions from code review * Format code. Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3608 so that emulator sets auth_time the same way production does (auth_time should match lastLoginAt in seconds)
Scenarios Tested
Added unit test to src/test/emulators/auth/misc.spec.ts called
"should populate auth_time to match lastLoginAt (in seconds since epoch)"This unit test...