feat(web): upgrade to support v9.8.1 Firebase JS SDK #8235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
reviewed
Jun 16, 2022
packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart
Outdated
Show resolved
Hide resolved
Lyokone
approved these changes
Jun 16, 2022
Salakar
reviewed
Jun 17, 2022
Co-authored-by: Elliot Hesp <elliot.hesp@gmail.com>
* refactor(analytics,web): v9 SDK refactor. * feat(firebase_analytics): provide isSupported for v9/analytics (#8899) * fix(analytics, web): use jsify with user properties (#8852) Co-authored-by: Benjamin Koch <koch@lotum.de> Co-authored-by: Jorge Roncero <60613199+jorgeroncero@users.noreply.github.com>
packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/settings.dart
Show resolved
Hide resolved
packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/settings.dart
Outdated
Show resolved
Hide resolved
* feat(storage, web): interate with web v9 SDK * feat(storage, web): bridge putString to uploadByteResumable (#8901) * chore(storage): rm unneeded api * chore(storage): rm unneeded class * chore(storage, web): rm unused code Co-authored-by: Guillaume Bernos <guillaume@bernos.dev>
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
…b/src/settings.dart Co-authored-by: Nils Reichardt <nils@reichardt.io>
|
Hey @jorgeroncero, I think something has messed up with the CLA agreement from this #8810. Do you mind signing it again for this? 😄 |
|
Hi there @russellwheatley, my CLA is not the problem this time. If I go to the details of the cla/google step, it says it's @Lyokone who has the problem? |
|
Weird, should be good now 👍 |
russellwheatley
changed the title
Salakar
approved these changes
Jul 5, 2022
russellwheatley
requested changes
Jul 5, 2022
packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/settings.dart
Outdated
Show resolved
Hide resolved
…b/src/settings.dart
russellwheatley
approved these changes
Jul 5, 2022
|
query.startAfterDocument(lastDocSnapshot); is not working some time on release mode only. In my app, there are five pages in my firestore can be fetched on dev mode correctly, but on release mode, there are only two pages. |
|
@LiangHuangBC Can you create a ticket with a reproducible example? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the internal Firebase JS SDK to latest v9.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?