Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: milliseconds support #2870

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Aditya-ds-1806
Copy link

This is an initial draft PR for the millisecond feature #1361. Would love to get your feedback on this up to this point.

@mvorisek
Copy link

@Aditya-ds-1806 as discussed in #1361 (comment) and #2520 (comment) at least nanosecond resolution should be supported, this PR should aim to provide general "fractional seconds" support

@Aditya-ds-1806
Copy link
Author

Got it, so you want me to increase the precision to 9 and preferably users should be able to configure it. Will try to push the changes in a few hours!

@Aditya-ds-1806
Copy link
Author

are the input elements configured to display a maximum of 4 digits somewhere? input.value.length doesnt go beyond 4 at all for some reason @mvorisek

@mvorisek
Copy link

4 digits? If you can get beyond 3 digits it should be not because of Date having only 3 digits/milli resolution - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date.

Please add tests and push the changes.

@Aditya-ds-1806
Copy link
Author

@mvorisek In that case should we leave it to the users to figure out how they want to format the millisecond input via the formatDate field? I have pushed the changes, please let me know

@radu-cs
Copy link

radu-cs commented Feb 23, 2024

Looking forward for this pull request to be merged.

@mvorisek
Copy link

This PR should be closed in favor of #2910 which added generic fractional seconds support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants