New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: milliseconds support #2870
base: master
Are you sure you want to change the base?
feat: milliseconds support #2870
Conversation
@Aditya-ds-1806 as discussed in #1361 (comment) and #2520 (comment) at least nanosecond resolution should be supported, this PR should aim to provide general "fractional seconds" support |
Got it, so you want me to increase the precision to 9 and preferably users should be able to configure it. Will try to push the changes in a few hours! |
are the input elements configured to display a maximum of 4 digits somewhere? |
4 digits? If you can get beyond 3 digits it should be not because of Please add tests and push the changes. |
@mvorisek In that case should we leave it to the users to figure out how they want to format the millisecond input via the |
Looking forward for this pull request to be merged. |
This PR should be closed in favor of #2910 which added generic fractional seconds support. |
This is an initial draft PR for the millisecond feature #1361. Would love to get your feedback on this up to this point.